Thrift
  1. Thrift
  2. THRIFT-6

Thrift libraries and compiler lack version number

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0
    • Fix Version/s: 1.0
    • Component/s: Build Process
    • Labels:
      None

      Description

      Right now it's impossible to tell which version of Thrift you have installed. If you're depending on features that have recently been added (and that subtly don't exist), you can spend a lot of time chasing your tail trying to figure out what the problem is.

      This may be something that has to be implemented piecemeal on each client library (ruby gem, java classes, etc). Thoughts?

      While we're at it, let's add a --version switch or something to the compiler so you know what version of stuff you're actually generating.

        Issue Links

          Activity

          Bryan Duxbury created issue -
          Bryan Duxbury made changes -
          Field Original Value New Value
          Summary No way to tell what version of Thrift libraries you have installed Thrift libraries and compiler lack version number
          Kevin Ballard made changes -
          Attachment 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch [ 12384558 ]
          Kevin Ballard made changes -
          Comment [ This patch (suitable for use with git-am) implements the -version switch on the compiler. A compiler/cpp/src/version.h file is generated when compiling that contains the THRIFT_VERSION and THRIFT_REVISION. A print_version.sh toplevel script is included (used to make version.h) that's suitable for use from language libraries if they wish to embed the current version/revision as well. ]
          Kevin Ballard made changes -
          Attachment 0001-Add-version-switch-to-the-compiler-to-show-the-thri.patch [ 12384558 ]
          Kevin Ballard made changes -
          Patch Info [Patch Available]
          Kevin Ballard made changes -
          Patch Info [Patch Available]
          Michael Greene made changes -
          Link This issue relates to THRIFT-274 [ THRIFT-274 ]
          Roger Meier made changes -
          Link This issue is related to THRIFT-363 [ THRIFT-363 ]
          Roger Meier made changes -
          Link This issue is related to THRIFT-71 [ THRIFT-71 ]
          Roger Meier made changes -
          Link This issue blocks THRIFT-956 [ THRIFT-956 ]
          Roger Meier made changes -
          Assignee Roger Meier [ roger.meier ]
          David Reiss made changes -
          Roger Meier made changes -
          Jake Farrell made changes -
          Link This issue is blocked by THRIFT-1259 [ THRIFT-1259 ]
          Roger Meier made changes -
          Fix Version/s 1.0 [ 12318851 ]
          Gavin made changes -
          Link This issue blocks THRIFT-956 [ THRIFT-956 ]
          Gavin made changes -
          Link This issue is depended upon by THRIFT-956 [ THRIFT-956 ]
          Roger Meier made changes -
          Roger Meier made changes -
          Attachment updateversion.sh [ 12598282 ]
          Jake Farrell made changes -
          Affects Version/s 1.0 [ 12318851 ]
          Component/s Build Process [ 12313845 ]

            People

            • Assignee:
              Roger Meier
              Reporter:
              Bryan Duxbury
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development