[THRIFT-688] cocoa: Memory management rules violated by -newProtocolOnTransport:

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Component/s: Cocoa - Library
• Patch Info: Patch Available
• Assignee: Kevin Ballard
• Reporter: Kevin Ballard
• Created: 22/Jan/10 23:29
• Updated: 01/Nov/11 02:52
• Resolved: 21/Jul/10 19:16

Description

The standard Cocoa memory management rules are not followed in the implementation/usage of -newProtocolOnTransport:. According to the memory management rules, methods starting with "new" return an owned object, but the current implementation of -[TBinaryProtocol newProtocolOnTransport:] (and its subsequent usage in TSocketServer) returns an autoreleased object instead. The attached patch fixes this, and can be verified by running the Clang Static Analyzer on the code both before and after the patch.