Thrift
  1. Thrift
  2. THRIFT-652

Generated field name for strut is not capitalized correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2
    • Fix Version/s: 0.5
    • Component/s: Haskell - Compiler
    • Labels:
      None
    • Environment:

      Mac OSX 10.6.2

    • Patch Info:
      Patch Available

      Description

      Generated field name for struct is not capitalized correctly. I have provided a patch to correct the problem. The errors occur in generated XXX_Types.hs.

        Issue Links

          Activity

          Walter Chang created issue -
          Walter Chang made changes -
          Field Original Value New Value
          Attachment t_hs_generator.patch [ 12428128 ]
          Hide
          Bryan Duxbury added a comment -

          Anyone with Haskell experience want to sign off on this patch? Otherwise, I'll probably just commit it.

          Show
          Bryan Duxbury added a comment - Anyone with Haskell experience want to sign off on this patch? Otherwise, I'll probably just commit it.
          Hide
          Sasha Rush added a comment -

          Looks good to me. We always should decapitalize.

          Show
          Sasha Rush added a comment - Looks good to me. We always should decapitalize.
          Hide
          Bryan Duxbury added a comment -

          I don't actually understand what's supposed to happen here. The patch doesn't give me enough context to indicate clearly what's happening. Am I supposed to be getting rid of the decapitalize call, or adding it?

          Show
          Bryan Duxbury added a comment - I don't actually understand what's supposed to happen here. The patch doesn't give me enough context to indicate clearly what's happening. Am I supposed to be getting rid of the decapitalize call, or adding it?
          Bryan Duxbury made changes -
          Fix Version/s 0.4 [ 12314960 ]
          Fix Version/s 0.3 [ 12314451 ]
          Bryan Duxbury made changes -
          Fix Version/s 0.5 [ 12315235 ]
          Fix Version/s 0.4 [ 12314960 ]
          Bryan Duxbury made changes -
          Fix Version/s 0.5 [ 12315235 ]
          Christian Lavoie made changes -
          Link This issue is part of THRIFT-918 [ THRIFT-918 ]
          Hide
          Christian Lavoie added a comment -

          I hit the same issue yesterday reviving various tests in the Haskell bindings: Haskell is sensitive to capitalization, similarly to how Ruby is.

          You're supposed to add the decapitalize calls; THRIFT-918 gives you a superset patch (that is sync'ed to head). My suggestion: commit THRIFT-918's v4 patch and close THRIFT-652 as resolved (and tested, thanks to the rest of the -918 patch).

          Show
          Christian Lavoie added a comment - I hit the same issue yesterday reviving various tests in the Haskell bindings: Haskell is sensitive to capitalization, similarly to how Ruby is. You're supposed to add the decapitalize calls; THRIFT-918 gives you a superset patch (that is sync'ed to head). My suggestion: commit THRIFT-918 's v4 patch and close THRIFT-652 as resolved (and tested, thanks to the rest of the -918 patch).
          Hide
          Christian Lavoie added a comment -

          This is fixed (and tested!) since my patches for THRIFT-918 were committed.

          Walter, please let me know if that's not the case; please close this issue if my fixes work for you too.

          Show
          Christian Lavoie added a comment - This is fixed (and tested!) since my patches for THRIFT-918 were committed. Walter, please let me know if that's not the case; please close this issue if my fixes work for you too.
          Christian Lavoie made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Christian Lavoie [ clavoie ]
          Fix Version/s 0.5 [ 12315235 ]
          Resolution Fixed [ 1 ]
          Jake Farrell made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Christian Lavoie
              Reporter:
              Walter Chang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development