[THRIFT-650] Make Check fails on Centos/OSX with 0.2.0 tarball

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.4

Environment

Centos 5.3 - Linux centos5_0 2.6.18-128.1.10.el5 #1 SMP Thu May 7 10:35:59 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux
Mac OSX 10.6.2 - Darwin nympro.local 10.2.0 Darwin Kernel Version 10.2.0: Tue Nov 3 10:37:10 PST 2009; root:xnu-1486.2.11~1/RELEASE_I386 i386 i386 MacBookPro4,1 Darwin

• Assignee: Anthony Molinaro
• Reporter: Anthony Molinaro
• Created: 15/Dec/09 07:42
• Updated: 02/May/10 23:06
• Resolved: 02/May/10 23:06

Description

% tar xvfz thrift-0.2.0-incubating.tar.gz && cd thrift-0.2.0
% ./configure && make && make check

fails with

UnitTestMain.cpp:21:45: error: boost/test/included/unit_test.hpp: No such file or directory

File above exists but not in given directory

% locate unit_test.hpp
/usr/include/boost/test/auto_unit_test.hpp
/usr/include/boost/test/unit_test.hpp

% rpm -qa | grep boost
boost-1.33.1-10.el5
boost-devel-1.33.1-10.el5

(same version of boost library on OSX, but installed via fink).

Changing the UnitTestMain.cpp to include boost/test/unit_test.cpp causes that file to compile but then
make check gives the following errors

TMemoryBufferTest.cpp:28: error: expected constructor, destructor, or type conversion before '(' token
TMemoryBufferTest.cpp:56: error: expected constructor, destructor, or type conversion before '(' token
TMemoryBufferTest.cpp:82: error: expected constructor, destructor, or type conversion before '(' token

Changing the header in TMemoryBufferTest.cpp from

#include <boost/test/unit_test.hpp>

to

#include <boost/test/auto_unit_test.hpp>

resulted in additional errors

TMemoryBufferTest.cpp:30: error: expected ',' or ';' before 'struct'
TMemoryBufferTest.cpp:30: error: 'test_roundtrip_id' was not declared in this scope
TMemoryBufferTest.cpp:30: error: template argument 1 is invalid
TMemoryBufferTest.cpp:107: error: expected ',' or ';' at end of input

And that's about as far as I can get not being a C++ type.