Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-650

Make Check fails on Centos/OSX with 0.2.0 tarball

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2
    • Fix Version/s: 0.4
    • Component/s: None
    • Labels:
      None
    • Environment:

      Description

      % tar xvfz thrift-0.2.0-incubating.tar.gz && cd thrift-0.2.0
      % ./configure && make && make check

      fails with

      UnitTestMain.cpp:21:45: error: boost/test/included/unit_test.hpp: No such file or directory

      File above exists but not in given directory

      % locate unit_test.hpp
      /usr/include/boost/test/auto_unit_test.hpp
      /usr/include/boost/test/unit_test.hpp

      % rpm -qa | grep boost
      boost-1.33.1-10.el5
      boost-devel-1.33.1-10.el5

      (same version of boost library on OSX, but installed via fink).

      Changing the UnitTestMain.cpp to include boost/test/unit_test.cpp causes that file to compile but then
      make check gives the following errors

      TMemoryBufferTest.cpp:28: error: expected constructor, destructor, or type conversion before '(' token
      TMemoryBufferTest.cpp:56: error: expected constructor, destructor, or type conversion before '(' token
      TMemoryBufferTest.cpp:82: error: expected constructor, destructor, or type conversion before '(' token

      Changing the header in TMemoryBufferTest.cpp from

      #include <boost/test/unit_test.hpp>

      to

      #include <boost/test/auto_unit_test.hpp>

      resulted in additional errors

      TMemoryBufferTest.cpp:30: error: expected ',' or ';' before 'struct'
      TMemoryBufferTest.cpp:30: error: 'test_roundtrip_id' was not declared in this scope
      TMemoryBufferTest.cpp:30: error: template argument 1 is invalid
      TMemoryBufferTest.cpp:107: error: expected ',' or ';' at end of input

      And that's about as far as I can get not being a C++ type.

        Attachments

        1. check.patch
          5 kB
          Anthony Molinaro
        2. check2.patch
          5 kB
          Adam Simpkins
        3. check3.patch
          5 kB
          Anthony Molinaro

          Activity

            People

            • Assignee:
              djnym Anthony Molinaro
              Reporter:
              djnym Anthony Molinaro
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: