Thrift
  1. Thrift
  2. THRIFT-647

PHP library is missing install target

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2
    • Fix Version/s: 0.4
    • Component/s: PHP - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      It would be useful when php is detected to install the php library on the system the same way other libraries are installed.

      To do this I added the attached Makefile.am into the lib/php directory and modifed configure.ac and lib/Makefile.am to cause automake to recognize it when PHP is installed. It defaults to installing in /usr/lib/php but can be overridden using the PHP_PREFIX environment variable, similar to python and java.

      1. Makefile.am
        0.9 kB
        Anthony Molinaro
      2. php.patch
        1 kB
        Anthony Molinaro
      3. ASF.LICENSE.NOT.GRANTED--v1-0001-THRIFT-647.-php-Add-license-header-and-fix-style-in-.patch
        3 kB
        David Reiss

        Activity

        Hide
        Bryan Duxbury added a comment -

        I just committed this.

        Show
        Bryan Duxbury added a comment - I just committed this.
        Hide
        David Reiss added a comment -

        Why was there a change to the Java generator in this commit?

        Show
        David Reiss added a comment - Why was there a change to the Java generator in this commit?
        Hide
        Bryan Duxbury added a comment -

        Ah, good catch. It looks like that was an unintentional leftover from one of my checkouts.

        Show
        Bryan Duxbury added a comment - Ah, good catch. It looks like that was an unintentional leftover from one of my checkouts.
        Hide
        Bryan Duxbury added a comment -

        (reverted the changes to the java lib)

        Show
        Bryan Duxbury added a comment - (reverted the changes to the java lib)
        Hide
        Bryan Duxbury added a comment -

        David - are you planning to apply that extra "style" patch you attached? I have no problem with you just committing it.

        Show
        Bryan Duxbury added a comment - David - are you planning to apply that extra "style" patch you attached? I have no problem with you just committing it.

          People

          • Assignee:
            Anthony Molinaro
            Reporter:
            Anthony Molinaro
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development