[THRIFT-638] BufferedTransport + C extensions block until recv timeout is reached on last fread call

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.7
• Component/s: PHP - Library
• Assignee: Nicholas Telford
• Reporter: Chris Goffinet
• Created: 29/Nov/09 07:08
• Updated: 07/Jan/15 23:01
• Resolved: 04/Mar/11 01:26

Description

I wanted to throw this out if any other folks experience this later on. At Digg we've been using the BufferedTransport + C extension of Thrift in PHP. Every so often, we will see spikes in latency increases on RPC calls that we know have acceptable response times (<200ms). This seems to happen based on how much data is being sent back over the wire. This is more of a PHP problem, but can be corrected in Thrift's PHP library for folks who don't want to upgrade PHP. I am still waiting to see if it's corrected in later versions (we use 5.2.9).

http://bonsai.php.net/bug.php?id=42720

Replacing the fread statements in TSocket.php with stream_socket_recvfrom correct this behavior so that calls do not wait until they hit the recv timeout.

Issue Links

• blocks: THRIFT-788 thrift_protocol.so: multiget/multiget_slice does not handle more than 17 keys correctly
• supercedes: THRIFT-347 PHP TSocket Timeout Issues