Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-577

Factor BinaryProtocolAccelerated into separate components

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Ben Maurer's excellent native Python library has proven to be very fast and efficient, however introducing new features and bug fixes have become a non-trivial task. This is because it implements the serialization process as a whole. The previous version of the Ruby library followed this approach, as it was actually based on Ben's library.

      Bryan split the Ruby native library in THRIFT-248, this has reduced the time for incorporating new features and bug fixes, and also has enabled other protocols to take advantage of the benefits of accelerated code (e.g. any protocol that inherits from TProtocol)

      The aim of this task is to split TBinaryProtocolAccelerated into separate pieces (e.g. TProtocolAccelerated, TBinaryProtocolAccelerated, etc.) and remove fastbinary.encode/decode from the Python generator.

        Activity

        Hide
        Robert Lu Robert Lu added a comment -

        The fastbinary.c is already move to lib/py/src/ext/ by THRIFT-3612.

        So, I think this issue is resolved.

        Show
        Robert Lu Robert Lu added a comment - The fastbinary.c is already move to lib/py/src/ext/ by THRIFT-3612 . So, I think this issue is resolved.

          People

          • Assignee:
            Unassigned
            Reporter:
            esteve Esteve Fernandez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development