[THRIFT-562] Java is inconsistent checking for required fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.2
• Patch Info: Patch Available
• Assignee: Jonathan Ellis
• Reporter: Jonathan Ellis
• Created: 14/Aug/09 15:33
• Updated: 01/Nov/11 02:52
• Resolved: 20/Aug/09 01:00

Description

In several places, the java generator does things like

// Most existing Thrift code does not use isset or optional/required,
// so we treat "default" fields as required.
bool is_optional = (*m_iter)->get_req() == t_field::T_OPTIONAL;

but it doesn't do so consistently. This replaces the remaining == REQUIRED checks with != OPTIONAL to also include fields in the DEFAULT state.

Issue Links

• blocks: CASSANDRA-308 Thrift client forwarding the null keys to the servers