[THRIFT-5576] fix old-style cast at const value ctor/copy and redundant copy at ctor

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0
• Component/s: C++ - Compiler
• Labels: easyfix
• Assignee: Kashirin Alex
• Reporter: Kashirin Alex
• Created: 30/Apr/22 16:51
• Updated: 27/Oct/22 02:46
• Resolved: 25/Aug/22 23:27

Description

The compiler warnings: of old-style cast

/root/swc-db/src/cc/include/swcdb/thrift/gen-cpp/Service_types.h: In constructor ‘SWC::Thrift::FU_LI::FU_LI()’:
/root/swc-db/src/cc/include/swcdb/thrift/gen-cpp/Service_types.h:3397:32: warning: use of old-style cast to ‘enum SWC::Thrift::FU_LIST_OP::type’ [-Wold-style-cast]
 3397 |           op((FU_LIST_OP::type)0),
      |                                ^
      |              -
      |              static_cast<     --
      |                               > (0)

The redundant copy at constructor

  FU_LB() noexcept
        : ctrl(0),
          op((FU_LIST_OP::type)0),
          pos(0) {
    op = (FU_LIST_OP::type)0;

  }
  virtual ~FU_LB() noexcept;

Issue Links

• links to: GitHub Pull Request #2597