[THRIFT-556] Ruby compiler does not correctly referred to top-level modules when a submodule masks the top-level name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: Ruby - Compiler
• Assignee: Ben Kelly
• Reporter: Evan Weaver
• Created: 09/Aug/09 16:13
• Updated: 09/Feb/12 17:17
• Resolved: 09/Feb/12 16:19

Description

Currently, if you set a top-level module for thrift/ruby that's the same name as an inner class, thrift does not reference the top level appropriately. Example bad code:

.thrift:

namespace rb Cassandra

.rb:

module Cassandra
module Cassandra
class Client
...
COLUMN_PARENT => {:type => ::Thrift::Types::STRUCT, :name => 'column_parent', :class => Cassandra::ColumnParent},

Ruby checks the inner module first, and does not find the class, raising an error.

The fix is to have every place that references the top-level module prepend it with '::':

COLUMN_PARENT => {:type => ::Thrift::Types::STRUCT, :name => 'column_parent', :class => ::Cassandra::ColumnParent},