[THRIFT-5480] TThreadPoolAsyncServer using TFramedTransport mistakenly drops client

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.15.0
• Fix Version/s: 0.16.0
• Component/s: netstd - Library
• Labels: Oneway TFramedTransport TThreadPoolAsyncServer
• Patch Info: Patch Available
• Flags: Patch

Language

C#

• Assignee: Jens Geyer
• Reporter: Ioannis Efthymiou
• Created: 13/Nov/21 10:16
• Updated: 15/Feb/22 21:41
• Resolved: 13/Nov/21 23:27

Description

TThreadPoolAsyncServer using TFramedTransport silently drops a client service using oneway methods when the second message is bigger than the first one.

I have an application implementing a one way service, depending on it's state. I created a TThreadpoolAsync server using the netstd 0.15 version, and I noticed that after a point, the notifications stopped coming, but there was no error on either side. The methods all worked individually, but some did not work after others.

Eliminating all possible causes on my side, I debugged the source code, and discovered that a transport exception was thrown from TEndpointTransport when a message size was bigger than the proceeding one, because TFramedTransport.ReadFrameAsync was not resetting the message size when it was done reading it, thus causing TEndpointTransport.UpdateKnownMessageSize to throw the exception. The server interpreted the exception as if the client had disconnected, so it silently ignored it.

 

I've attached a patch that corrects this behaviour

Issue Links

• links to: GitHub Pull Request #2478