[THRIFT-5472] Fix the "latest" version of go library recognized by the go toolchain

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Assignee: Yuxuan Wang
• Reporter: Yuxuan Wang
• Created: 16/Oct/21 22:34
• Updated: 18/Oct/21 20:44
• Resolved: 18/Oct/21 20:43

Description

Because of a previously failed attempt of THRIFT-5338, there's a git commit (e27e82c) on the master branch with lib/go/thrift/go.mod file. Although that file was removed in a later commit (d9fcdd3), the existence of e27e82c confused the go toolchain in the following ways:

1. `go get github.com/apache/thrift/lib/go/thrift@latest` will always import e27e82c (`go get github.com/apache/thrift@latest` will import the correct latest version)
2. pkg.go.dev will also prompt people that e27e82c is the "latest" version, over v0.15.0

With the help of go team the solution to fix it is to:

1. Create a commit, not necessarily need to be on master branch, with lib/go/thrift/go.mod file with the line of `retract [v0.0.0-00000000000000-000000000000, v0.0.1-do-not-use]` with an explanation of retract reason.
2. Tag that commit with `lib/go/thrift/v0.0.1-do-not-use` and push the tag to github.
3. On github releases page, mark that tag as a pre-release.

 

Issue Links

• links to: GitHub Pull Request #2468