[THRIFT-5439] Lua Generator does not support const i64

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.14.2
• Fix Version/s: 0.15.0
• Component/s: Lua - Compiler
• Labels: easyfix
• External issue URL: https://github.com/apache/thrift/pull/2413
• Assignee: KaibinHuang
• Reporter: KaibinHuang
• Created: 05/Jul/21 07:47
• Updated: 11/Sep/21 12:31
• Resolved: 17/Jul/21 12:52

Description

 in thrift file:
const i64 ALuaConst= 0x1

in generated lua file:
ALuaConst = lualongnumber.new('')

bug is here:
https://github.com/apache/thrift/blob/4434ee92d5141578cecac95ee53e3563101b9ecd/compiler/cpp/src/thrift/generate/t_lua_generator.cc#L262
should replace get_string() with get_integer()
beacuse according to
https://github.com/apache/thrift/blob/4434ee92d5141578cecac95ee53e3563101b9ecd/compiler/cpp/src/thrift/parse/t_scope.h#L153
when const type == i64, set_string() is unreachable, then get_string() will always return "".

Issue Links

• links to: GitHub Pull Request #2413