[THRIFT-5429] build: autotools: add foreign to AM_INIT_AUTOMAKE

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.9, 0.9.1, 0.9.2, 0.9.3, 0.9.3.1, 0.10.0, 0.11.0, 0.12.0, 0.13.0, 0.14.0, 0.14.1
• Fix Version/s: 0.15.0
• Component/s: Build Process

Environment

Any platform where autotools is available (so really any platform).

I'll create a PR on github - it's a one-liner.

• Flags: Patch
• Assignee: Christopher Friedt
• Reporter: Christopher Friedt
• Created: 05/Jun/21 11:56
• Updated: 11/Sep/21 12:31
• Resolved: 07/Jun/21 21:22

Description

Add "foreign" to "AM_INIT_AUTOMAKE()" in "configure.ac" to prevent autoreconf complaining about "missing" files. Autotools projects have historically required these to be present, but their absense is less critical these days.

$ autoreconf -vfi
...
Makefile.am: error: required file './NEWS' not found
Makefile.am: error: required file './README' not found
Makefile.am: error: required file './AUTHORS' not found
Makefile.am: error: required file './ChangeLog' not found
...

Also removed the "--foreign" argument from automake in bootstrap.sh

Issue Links

• links to: GitHub Pull Request #2405