Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5425

Throw an exception when reading TSimpleJson in Java

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.15.0
    • Component/s: Java - Library
    • Labels:
      None

      Description

      The current java implementation silently skips reading TSimpleJson which results in an empty object. When not familiar with TSimpleJson silently not reading anything causes confusion.
      If possible I would like to remove the todo comments, update the reader comment and throw a TException("Not implemented").
      This same exception approach is present in the PHP and Python read implementations.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                thomasbruggink Thomas Bruggink
                Reporter:
                thomasbruggink Thomas Bruggink
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h