[THRIFT-5420] Go library should not depend on "testing" in the main package

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.14.0, 0.14.1
• Component/s: Go - Library
• Assignee: Unassigned
• Reporter: Yuri Shkuro
• Created: 24/May/21 20:30
• Updated: 24/May/21 23:35

Description

From https://github.com/jaegertracing/jaeger-client-go/issues/585:

Describe the bug
Importing jaeger-client-go adds a dependency on the standard library "testing" package. This is undesirable because production Go programs should not depend on the testing package. In addition to unnecessary bloat, "testing" adds a bunch of command line flags.

The dependency is coming from https://github.com/apache/thrift/blob/66d897667c451ef6560d89b979b7001c57a3eda6/lib/go/thrift/logger.go#L58

Recommendation

Move TestLogger to a sub-module like "testutils". Or remove completely since it's a trivial implementation that can be easily reproduced. Or replace testing.TB argument with a locally defined interface that exposes Errorf function.