Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5412

TSocket and TEndpointTransport should not throw TTransportException

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 0.14.1
    • None
    • Java - Library
    • None

    Description

      In Thrift 0.14.1, a new TSocket constructor is provided,
      ```
      public TSocket(TConfiguration config, String host, int port, int socketTimeout, int connectTimeout) throws TTransportException
      ```

      The method will throw an exception TTransportException.
      The exception is inherented from `TEndpointTransport.resetConsumedMessageSize()`.

      However, as the constructor calls `TEndpointTransport.resetConsumedMessageSize(-1)`, which will never throw such an exception, I think we can remove the exception declaration in TSocket's constructor.

      Attachments

        Activity

          People

            Unassigned Unassigned
            hxd Xiangdong Huang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: