Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5369

Malformed payload can still cause huge allocations

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.14.1
    • Fix Version/s: 0.15.0, 0.14.2
    • Component/s: Go - Compiler
    • Labels:
      None

      Description

      While testing Jaeger with the fix provided as part of THRIFT-5322, users in our community reported that they are still seeing huge allocations when malformed packets are received by our backend (jaeger-agent). See the discussion starting from this comment by vchirikov on Mar 5.

      Based on the comment from Yuxuan Wang in the issue linked above, I understand that the issue should be addressed at both the compiler and the Go library:

      The sanity check on container header should be done in thrift go library (github.com/apache/thrift/lib/go/thrift)

      If you want to avoid allocation of the containers upfront after it passed the header sanity check, then that needs to be don in thrift compiler (in generated go code)

        Attachments

          Activity

            People

            • Assignee:
              fishywang Yuxuan Wang
              Reporter:
              jpkroehling Juraci Paixão Kröhling
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 10m
                2h 10m