Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5358

Add go.mod file(s)

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.14.0
    • 0.15.0
    • Go - Library
    • None

    Description

      Go 1.16 already disallowed building without go.mod file by default (still override-able with GO111MODULES=auto environment variable), and Go 1.17 will remove that override option, so we need to add go.mod file(s) to unblock developers working on tip and using Go 1.16+.

      Based on the current discussion on https://github.com/golang/go/issues/34055, we probably will need to add 2 go.mod files:

      1. one under lib/go/thrift for our users to use. A release process change is also required because of this file: for all the future releases, we would need to double tag with "lib/go/thrift/" prefix (e.g. for 0.15.0 release we would need to git tag "v0.15.0" and "lib/go/thrift/v0.15.0" on the same commit)
      2. another under root for the tests to work on Go 1.16+

      Attachments

        Issue Links

          Activity

            People

              fishywang Yuxuan Wang
              fishywang Yuxuan Wang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 40m
                  1h 40m