[THRIFT-5292] No Need to Explicitly Print Null

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: Java - Compiler
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 08/Oct/20 02:11
• Updated: 05/Feb/21 10:20

Description

if (!first) sb.append(", ");
 sb.append("i16_list:");
 if (this.i16_list == null) {
 sb.append("null");
 } else {
 sb.append(this.i16_list);
 }

The overall effect is exactly as if the argument were converted to a string by the method String.valueOf(Object), and the characters of that string were then appended to this character sequence.

if the argument is null, then a string equal to "null"; otherwise, the value of obj.toString() is returned.

So, Thrift doesn't need to manually append 'null' here, can reduce the code here.

Issue Links

• links to: GitHub Pull Request #2257