[THRIFT-5274] Thrift 0.13.0 does not work with JDK8

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Java - Library
• Assignee: Christopher Tubbs
• Reporter: Colm O hEigeartaigh
• Created: 08/Sep/20 10:35
• Updated: 11/Feb/21 22:27
• Resolved: 04/Feb/21 21:15

Description

Thrift 0.13.0 does not work with JDK8, as it is compiled with JDK11. Even though the source version is JDK8, incorrect byte code is generated for various ByteBuffer methods, e.g.:

Exception in thread "TAsyncClientManager#SelectorThread 22" java.lang.NoSuchMethodError: java.nio.ByteBuffer.rewind()Ljava/nio/ByteBuffer;

The fix is suggested in this blog post: https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/

We can add the release flag for 1.8 (-release=8).

Issue Links

• relates to: SPARK-34128 Suppress excessive logging of TTransportExceptions in Spark ThriftServer
• links to: GitHub Pull Request #2231
• links to: GitHub Pull Request #2325