[THRIFT-5260] Fix the thrift compiler generate problematic lua code for the oneway method

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Lua - Compiler
• Assignee: zero
• Reporter: zero
• Created: 04/Aug/20 13:21
• Updated: 11/Feb/21 22:27
• Resolved: 12/Sep/20 17:05

Description

The oneway method 'testOneway' in file 'test/ThriftTest.thrift', for instance, generated code in file 'test/lua/gen-lua/ThriftTest_ThriftTest.lua' as follows:

function ThriftTestProcessor:process_testOneway(seqid, iprot, oprot, server_ctx)
local args = testOneway_args:new{}
local reply_type = TMessageType.REPLY
args:read(iprot)
iprot:readMessageEnd()
local result = testOneway_result:new{}
local status, res = pcall(self.handler.testOneway, self.handler, args.secondsToSleep)
if not status then
reply_type = TMessageType.EXCEPTION
result = TApplicationException:new

{message = res}

else
result.success = res
end
oprot:writeMessageBegin('testOneway', reply_type, seqid)
result:write(oprot)
oprot:writeMessageEnd()
oprot.trans:flush()
end

The 'testOneway_result' is undefined and I think it is wrong to write the 'result' to the 'oprot' since it is nil, but at the same time it is necessary for every process functions to return values from each handler's return.

 

I have created a pull request here: https://github.com/apache/thrift/pull/2212

Issue Links

• links to: GitHub Pull Request #2212