[THRIFT-5257] Go THeader implementation doesn't handle endOfFrame correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Go - Library
• Assignee: Yuxuan Wang
• Reporter: Yuxuan Wang
• Created: 29/Jul/20 16:56
• Updated: 11/Feb/21 22:27
• Resolved: 30/Jul/20 16:24

Description

In the current implementation, we only call endOfFrame when we hit EOF when reading from the frameReader. The problem is in go stdlib the read action finished reading the remaining data from frameReader will not return EOF, the next Read will. This caused us in most cases only call endOfFrame at the beginning of the next frame, which could cause troubles because we didn't read the beginning of the frame properly.

Issue Links

• links to: GitHub Pull Request #2209