Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5257

Go THeader implementation doesn't handle endOfFrame correctly

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.13.0
    • 0.14.0
    • Go - Library
    • None

    Description

      In the current implementation, we only call endOfFrame when we hit EOF when reading from the frameReader. The problem is in go stdlib the read action finished reading the remaining data from frameReader will not return EOF, the next Read will. This caused us in most cases only call endOfFrame at the beginning of the next frame, which could cause troubles because we didn't read the beginning of the frame properly.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            fishywang Yuxuan Wang
            fishywang Yuxuan Wang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment