[THRIFT-5241] Make C++ library build on OS X and iOS

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9
• Component/s: C++ - Library
• Labels: c++ ios mac

Environment

Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain. Also fixes iOS xcode 4.4 with clang 4.0 toolchain.

• Patch Info: Patch Available
• Assignee: Mario Emmenlauer
• Reporter: John Arthur Kleiven
• Created: 28/Jun/20 08:58
• Updated: 01/Sep/21 12:04
• Resolved: 01/Sep/21 12:04

Description

Various small issues keep the existing Thrift c++ libraries from building on OS X and iOS. For example, in Clang, there is no <tr1/functional>, only a regular <functional>. Instead of adding a new configure token and a million #ifdefs, the patch has added a wrapper header that throws the relevant <functional> symbols into the apache::thrift:stdcxx namespace.

There are also several fixes for unused variable warnings in release mode. I have added a helper macro to better document these cases (as opposed to just adding the mysterious "ret=ret;" everywhere).

Issue Links

• is a clone of: THRIFT-1740 Make C++ library build on OS X and iOS