[THRIFT-5234] Fix a number of js/ts generation issues

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: JavaScript - Compiler
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 17/Jun/20 22:34
• Updated: 11/Feb/21 22:27
• Resolved: 17/Jun/20 22:39

Description

The following text stems from the original PR by Phil Price:

 

Fix a number of js/ts generation issues:

• [js] Missing class name for generated services and processors; this makes instrumentation of outbound calls (e.g. which service are we calling in to) difficult. Generating a class name for es6 enables x.constructor.name to get generated name.
• [js] Fix case where services have a method with an argument named "params", generated code generates an identifier in the "send_XXX" body named "params" which conflicts with the argument. Ensure the identifier in the body is uniquely named.
• [js] Ensure that derived services (extends XYZService) correctly call super() in their constructor.
• [ts] Ensure that derived services (extends XYZSerice) correctly specify the base class Client and Processor name
• [js] Ensure that derived service clients do not redefine private fields (output, pClass, _seqId, _reqs) and call super();
• [ts] Ensure derived service clients and processors do not redefine private fields in declaration.
• [js] Missing class name for generated services and processors; this makes instrumentation of outbound calls (e.g. which service are we calling in to) difficult. Generating a class name for es6 enables x.constructor.name to get generated name.
• [js] Fix case where services have a method with an argument named "params", generated code generates an identifier in the "send_XXX" body named "params" which conflicts with the argument. Ensure the identifier in the body is uniquely named.
• [js] Ensure that derived services (extends XYZService) correctly call super() in their constructor.
• [ts] Ensure that derived services (extends XYZSerice) correctly specify the base class Client and Processor name
• [js] Ensure that derived service clients do not redefine private fields (output, pClass, _seqId, _reqs) and call super();
• [ts] Ensure derived service clients and processors do not redefine private fields in declaration.

Issue Links

• links to: GitHub Pull Request #1855
• links to: pull request