[THRIFT-520] Constants break when a namespace/prefix is set.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: Cocoa - Compiler
• Patch Info: Patch Available
• Assignee: Andrew McGeachie
• Reporter: Fred Potter
• Created: 05/Jun/09 07:45
• Updated: 01/Nov/11 02:54
• Resolved: 21/Jul/09 16:12

Description

Given the following thrift file:

namespace cocoa XX 

const list<string> MY_THINGS = [ "a", "b", "c" ]
const string MY_CONSTANT = "Hello!"

The generated class looks like:

static NSArray * XXMY_THINGS;
static NSString * XXMY_CONSTANT = @"Hello!";

@implementation XXfooConstants
+ (void) initialize {
  MY_THINGS = [[NSArray alloc] initWithObjects: @"a", @"b", @"c", nil];
}
+ (NSArray *) MY_THINGS{
  return MY_THINGS;
}
+ (NSString *) MY_CONSTANT{
  return MY_CONSTANT;
}
@end

... but, it needs to look as it does below with the correct prefixing in the initialize and getter methods:

static NSArray * XXMY_THINGS;
static NSString * XXMY_CONSTANT = @"Hello!";

@implementation XXfooConstants
+ (void) initialize {
  XXMY_THINGS = [[NSArray alloc] initWithObjects: @"a", @"b", @"c", nil];
}
+ (NSArray *) MY_THINGS{
  return XXMY_THINGS;
}
+ (NSString *) MY_CONSTANT{
  return XXMY_CONSTANT;
}
@end