[THRIFT-5208] OCaml codegen exception pattern match syntax error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.18.0
• Component/s: OCaml - Compiler
• Assignee: Yawar Amin
• Reporter: Yawar Amin
• Created: 13/May/20 18:12
• Updated: 13/Feb/23 21:10
• Resolved: 08/Sep/22 22:48

Description

For the following exception:

exception Ex {
1:  required string message
}

The following class and exception are generated:

class ex : object ('a)
  ...
end
exception Ex of ex
...
(try ...
with
  | ex e -> ...

This is a syntax error as all constructors (like ex) must start with an uppercase letter. It can be fixed by outputting | Ex e -> ....

Issue Links

• links to: GitHub Pull Request #2652
• links to: GitHub Pull Request #2657