Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5190

StringUtils haven't take `(offset + length) > bytes.length` into account

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: Java - Library
    • Labels:
      None

      Description

      1. haven't take ‘(offset + length) > bytes.length' into account;
      2. `if ((offset | length | (offset + length) | (size - (offset + length))) < 0)` will faster than `>`

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dugenkui dugenkui
                Reporter:
                dugenkui dugenkui
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h