[THRIFT-5164] Go middleware support

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Go - Library
• Labels: Breaking-Change
• Assignee: Duru Can Celasun
• Reporter: Yuxuan Wang
• Created: 03/Apr/20 00:59
• Updated: 11/Feb/21 22:26
• Resolved: 27/Apr/20 18:33

Description

I saw that this idea was discussed before in THRIFT-4553, but want to reopen the discussion to see if there's a change of mind.

We (Reddit) recently implemented TProcessor level middleware support in our Baseplate.go library, and we think that our implementation is generic enough that it might make sense to contribute that into the thrift library. The related implementation are all in this file: https://github.com/reddit/baseplate.go/blob/4225e42dc8dde56b222ac7ea3a4ff63aa726f6a6/thriftbp/middlewares.go

https://github.com/reddit/baseplate.go/blob/4225e42dc8dde56b222ac7ea3a4ff63aa726f6a6/tracing/middlewares.go#L40-L64 is an example of how a tracing middleware is implemented.

If we think that's a good idea, then we can contribute that into thrift repo (with renames, of course). One implementation detail I'm not sure is that whether we want to expand the TProcessor interface to also include ProcessorMap and AddToProcessorMap, or do we want to keep the two iinterfaces separate.

Issue Links

• links to: GitHub Pull Request #2119
• links to: GitHub Pull Request #2126
• links to: GitHub Pull Request #2128