Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5163

adds Q to exports for browserify

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: Node.js - Library
    • Labels:
      None

      Description

      From pull request:

      NodeJS: adds Q to exports for browserify

      When using the Node.js libs in the browser (via browser.js) Q isn't
      exposed the same way as it is in a Node environment. If I try to call
      an API function without a callback function it will throw the following
      exception: TypeError: Cannot read property 'defer' of undefined. This
      just adds Q to the exports in browser.js to make consuming the libs
      more consistent with how we do in an actual Node environment.

        Attachments

          Activity

            People

            • Assignee:
              jensg Jens Geyer
              Reporter:
              jensg Jens Geyer
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10m
                10m