[THRIFT-516] If TFramedTransport reads a negative frame size, throw a TTransportException descendant instead of the default NegativeArraySizeException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1, 0.2
• Fix Version/s: 0.2
• Component/s: Java - Library
• Patch Info: Patch Available
• Assignee: Bryan Duxbury
• Reporter: Bryan Duxbury
• Created: 22/May/09 17:36
• Updated: 22/May/09 21:05
• Resolved: 22/May/09 21:05

Description

If TFramedTransport manages to read a negative-sized frame header off the wire, it will blithely try to create a buffer with negative size. This throws a NegativeArraySizeException, which is a undeclared exception type. The upshot is that even if you are catching TTransportExceptions, you will end up with an untrapped exception, which seems stupid.

We should check if the size is negative and throw an appropriate declared exception instead.