[THRIFT-5138] Swift generator does not escape keywords properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.14.0
• Fix Version/s: 0.14.0
• Component/s: Swift - Compiler
• Labels: breaking_change
• Assignee: Jano Svitok
• Reporter: Jano Svitok
• Created: 12/Mar/20 23:39
• Updated: 11/Feb/21 22:26
• Resolved: 19/May/20 22:59

Description

1. For field `protocol` in a struct:
generated:

    try proto.validateValue(protocol, named: "protocol")

expected:

    try proto.validateValue(`protocol`, named: "protocol")

2. Swift allows any keyword to be used as identifier if you escape it, so lang_keywords() should return empty set.
Adjust keyword test appropriately.

3. kewords_(lang_keywords()) initialization in t_generator.h does not work. Virtual method call from base class constructor. This mechanism is used for Python and Swift. Fixing this issue changes list of reserved words for Python and Swift (breaking change).

https://github.com/apache/thrift/pull/2059

Issue Links

• links to: GitHub Pull Request #2059