Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5121

Logic bug in TMultiplexedProcessor – Swift

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      A previous patch (https://github.com/apache/thrift/pull/2002) for https://issues.apache.org/jira/browse/THRIFT-5084 added multiplexing support but contained a logical error when checking the message type. It should allow `oneway` and `call` message types and reject all others, but it rejected `oneway` and `call` messages and accepted all others.

       

      I've fixed the bug and updated the unit tests. GitHub PR linked. My apologies for any inconvenience caused.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            alexanderedge Alexander Edge
            alexanderedge Alexander Edge
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Issue deployment