[THRIFT-5121] Logic bug in TMultiplexedProcessor – Swift

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Swift - Library
• Labels: multiplexing
• Assignee: Alexander Edge
• Reporter: Alexander Edge
• Created: 27/Feb/20 11:31
• Updated: 11/Feb/21 22:26
• Resolved: 14/Mar/20 14:42

Description

A previous patch (https://github.com/apache/thrift/pull/2002) for https://issues.apache.org/jira/browse/THRIFT-5084 added multiplexing support but contained a logical error when checking the message type. It should allow `oneway` and `call` message types and reject all others, but it rejected `oneway` and `call` messages and accepted all others.

 

I've fixed the bug and updated the unit tests. GitHub PR linked. My apologies for any inconvenience caused.

Issue Links

• links to: GitHub Pull Request #2036