[THRIFT-5105] Very minor issue: why are the values for "unlimited" different between Java and cpp?

• Type: Improvement
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 0.13.0
• Component/s: C++ - Library
• Assignee: Unassigned
• Reporter: Mario Emmenlauer
• Created: 20/Feb/20 09:09
• Updated: 06/Mar/20 09:39

Description

I've seen that in Java, https://github.com/apache/thrift/blob/882d48da5d5db439c11029f46006c71f6429ae2c/lib/java/src/org/apache/thrift/protocol/TBinaryProtocol.java#L34 defines a constant NO_LENGTH_LIMIT = -1 to initialize string_limit and container_limit of TBinaryProtocol. In C++ on the other hand, the default values (I guess they represent unlimited) are set in https://github.com/apache/thrift/blob/042580f53441efe1bc5c80c89351fcb30740659e/lib/cpp/src/thrift/protocol/TBinaryProtocol.h#L47 with string_limit_(0).

 

This is really no big issue but for consistency it may be nicer if all implementation use the same default for "unlimited"?