[THRIFT-5093] lib: cpp: test: clarify effect of MemoryPolicy on TMemoryBuffer

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.17.0
• Fix Version/s: 0.17.0
• Component/s: C++ - Library
• Assignee: Christopher Friedt
• Reporter: Christopher Friedt
• Created: 14/Feb/20 15:56
• Updated: 26/Oct/22 23:46
• Resolved: 19/Apr/22 16:51

Description

My main use case for TMemoryBuffer was that I wanted to be able to call resetBuffer() on OBSERVE buffers and reuse the contents for test cases over and over. While the default resetBuffer() cannot be used for that purpose, the same result can be achieved by calling resetBuffer(ro_mem, ro_mem_size, OBSERVE) as well, so the workaround is fairly trivial.

While the former implementation would be more convenient in some cases, it makes more sense to have consistent behaviour for all resetBuffer() implementations.

Added test cases to clarify the effect of MemoryPolicy on TMemoryBuffer behaviour.

Issue Links

• links to: GitHub Pull Request #2007