Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5086

CMake target thrift::thrift has no INTERFACE_INCLUDE_DIRECTORIES property

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.13.0
    • 0.14.0
    • C++ - Library
    • None
    • Patch Available
    • Patch

    Description

      linking projects against thrift::thrift target failed due to missed INTERFACE_INCLUDE_DIRECTORIES property

      // to fix apply patch
      
      diff --git a/build/cmake/ThriftMacros.cmake b/build/cmake/ThriftMacros.cmake
      index d068b2a..038651e 100644
      --- a/build/cmake/ThriftMacros.cmake
      +++ b/build/cmake/ThriftMacros.cmake
      @@ -25,6 +25,7 @@ endmacro(ADD_PKGCONFIG_THRIFT)
       
       macro(ADD_LIBRARY_THRIFT name)
           add_library(${name} ${ARGN})
      +    target_include_directories(${name} INTERFACE $<INSTALL_INTERFACE:include>)
           set_target_properties(${name} PROPERTIES
               OUTPUT_NAME ${name}${THRIFT_RUNTIME_POSTFIX}   # windows link variants (/MT, /MD, /MTd, /MDd) get different names
               VERSION ${thrift_VERSION} )
      

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            smartnet SmartNet Club
            smartnet SmartNet Club
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Issue deployment