[THRIFT-5069] Go: TDserializer is not resource pool friendly

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.0
• Component/s: Go - Library
• Assignee: Unassigned
• Reporter: Yuxuan Wang
• Created: 17/Jan/20 05:05
• Updated: 11/Feb/21 22:26
• Resolved: 18/Jan/20 20:56

Description

Currently TSerializer is resource pool friendly (see here for an example), but TDeserializer is not. When putting a TDeserializer back into resource pool, some extra works need to be done:

defer func() {
	deserializer.Transport.(*thrift.TMemoryBuffer).Reset()
	deserializerPool.Put(deserializer)
}()

If we change the type of TDeserializer.Transport to *TMemoryBuffer, and also call Transport.Reset() at the beginning of Read and ReadString (we already do both in TSerializer), it will make it more resource pool friendly.

This will be a breaking change, though.

Issue Links

• links to: GitHub Pull Request #1987