[THRIFT-5028] TEvHttpServer don't work under cygwin ( or windows)

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.10.0, 0.11.0, 0.12.0, 0.13.0
• Component/s: C++ - Library

Environment

Tested: cygwin64 under windows 10, may affect all cygwin or windows systems

• Patch Info: Patch Available
• Flags: Patch
• Assignee: Unassigned
• Reporter: Zhenghui Zhou
• Created: 24/Nov/19 05:12
• Updated: 24/Nov/19 05:12

Description

In my environment, TEvHttpServer don't work under Cygwin64 under window 10.

Call to evhttp_bind_socket() fails to bind any network interface under windows, since a NULL pointer of the ip address string parameter is used. By contrast, in the examples of libevent, the string "0.0.0.0" is used and can bind successfully under all known platforms.

Example:

test.thrift

namespace cpp test
service Test {
  i32 foo();
}

thrift --gen cpp:cob_style test.thrift

evhttp_thrift_server.cpp:

#include <thrift/protocol/TBinaryProtocol.h>
#include <thrift/async/TAsyncProtocolProcessor.h>
#include <thrift/async/TEvhttpServer.h>
#include "gen-cpp/Test.h"

using apache::thrift::protocol::TBinaryProtocolFactory;
using apache::thrift::protocol::TProtocolFactory;
using apache::thrift::async::TEvhttpServer;
using apache::thrift::async::TAsyncProcessor;
using apache::thrift::async::TAsyncBufferProcessor;
using apache::thrift::async::TAsyncProtocolProcessor;
using namespace ::apache::thrift;
using namespace ::test;

class TestHandle : public TestCobSvIf {
public:
  void foo(thrift::stdcxx::function <void(int32_t const& _ret)> cob) { return cob(0); }
}

int main() {
  stdcxx::shared_ptr<TestHandle> service(new TestHandle());
  stdcxx::shared_ptr<TAsyncProcessor> proc(new TestAsyncProcessor(service));
  stdcxx::shared_ptr<TProtocolFactory> pfact(new TBinaryProtocolFactory());
  stdcxx::shared_ptr<TAsyncBufferProcessor> bufproc(new TAsyncProtocolProcessor(proc, pfact));
  stdcxx::shared_ptr<TEvhttpServer> server(new TEvhttpServer(bufproc, 8000));
  server->serve();
  return 0;
}

Compile and run it, everything seems ok, but a "netstat -a" on a new terminal window can tell that there is no service binding to port 8000 of any network interfaces.