[THRIFT-5014] Do Direct Comparison on Raw Values Instead of Objects

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Java - Compiler
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Nov/19 01:55
• Updated: 18/May/22 21:12
• Resolved: 18/May/22 21:12

Description

Java compiler currently generates:

    lastComparison = java.lang.Boolean.valueOf(isSetName()).compareTo(other.isSetName());
    if (lastComparison != 0) {
      return lastComparison;
    }

Instead, use Boolean#compare to compare the raw values instead of having to call Boolean.ValueOf first.

Issue Links

• links to: GitHub Pull Request #1935