Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5014

Do Direct Comparison on Raw Values Instead of Objects

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.13.0
    • Fix Version/s: None
    • Component/s: Java - Compiler
    • Labels:
      None

      Description

      Java compiler currently generates:

          lastComparison = java.lang.Boolean.valueOf(isSetName()).compareTo(other.isSetName());
          if (lastComparison != 0) {
            return lastComparison;
          }
      

      Instead, use Boolean#compare to compare the raw values instead of having to call Boolean.ValueOf first.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                belugabehr David Mollitor
                Reporter:
                belugabehr David Mollitor
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m