[THRIFT-5010] BinaryPrimitives.Read/WriteInt32BigEndian should be used to convert to/from network byte order

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: netstd - Library
• Labels: features
• Assignee: Edward Zhuravlov
• Reporter: Edward Zhuravlov
• Created: 15/Nov/19 07:47
• Updated: 11/Feb/21 22:27
• Resolved: 23/Nov/19 21:27

Description

Conversion should be from/to TCP protocol format (always big-Endian) to execution engine based on processor architecture. See System.BitConverter class ():

https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter?view=netstandard-2.0

 The endianness of an architecture is indicated by the IsLittleEndian property, which returns true on little-endian systems and false on big-endian systems. On little-endian systems, lower-order bytes precede higher-order bytes. On big-endian system, higher-order bytes precede lower-order bytes. 

Recomended use BinaryPrimitives.WriteInt32BigEndian/ReadInt32BigEndian class from nuget System.Memory by Microsoft for NetStandard 2.0.

 

Issue Links

• links to: GitHub Pull Request #1944