[THRIFT-5003] Websocket Connection in Browsers with nodejs code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Node.js - Library, TypeScript - Library
• Labels: Browser JavaScript WebSocket webpack

Environment

Webpack 4.41.2

Thrift 0.13.0

NodeJS thrift lib required in browser env

• Patch Info: Patch Available
• Assignee: Eugen Kandakov
• Reporter: Eugen Kandakov
• Created: 12/Nov/19 00:35
• Updated: 11/Feb/21 22:26
• Resolved: 07/Jan/20 14:29

Description

After some changes to the ws_connection.js file in the nodejs code, I could create a version of the WSConnection, createWSConnection and createWSClient which is able to run similar code of WebSocket connections in the browser and NodeJS

Solution is package, `isomorphic-ws` which provides the proper Websocket libs depending on the env (browser or node)

 

Testable Repo with thrift branch from PR: https://github.com/alabama/thrift-testing

Issue Links

• links to: GitHub Pull Request #1927