[THRIFT-4984] Scary and spammy "error processing request: EOF" logs from TSimpleServer

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Go - Library
• Assignee: Unassigned
• Reporter: Yuxuan Wang
• Created: 22/Oct/19 23:20
• Updated: 11/Feb/21 22:26
• Resolved: 05/Nov/19 21:31

Description

After upgraded our code to 0.13.0, we noticed a lot of the logs in stderr:

2019/10/22 22:04:52 error processing request: EOF

I think they are generated by this line https://github.com/apache/thrift/blob/v0.13.0/lib/go/thrift/simple_server.go#L167, which means EOF is an error returned by processRequests function.

In that function we actually treat some EOF errors as non-errors (example), so I think it's just that we missed some cases and didn't treat all harmless EOF errors as non-errors.

Issue Links

• links to: GitHub Pull Request #1904
• links to: GitHub Pull Request #1907
• links to: GitHub Pull Request #1922