Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4969

PHP test doesn't check the code generation with php:classmap

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Test Suite
    • Labels:
      None

      Description

      In test/php/Makefile.am:

       20 stubs: ../ThriftTest.thrift
       21         $(THRIFT) --gen php ../ThriftTest.thrift
       22         $(THRIFT) --gen php:inlined ../ThriftTest.thrift
       23         $(MKDIR_P) gen-php-classmap
       24         $(THRIFT) -out gen-php-classmap --gen php ../ThriftTest.thrift
      

      The last command generates the same code as the first one's. It should test --gen php:classmap option instead of --gen php.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sekikn Kengo Seki
                Reporter:
                sekikn Kengo Seki
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m