[THRIFT-4962] Deadlock in TimerManager::stop

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: C++ - Library
• Labels: pull-request-available
• External issue URL: https://github.com/apache/thrift/pull/1877
• Assignee: Guillaume Blanc
• Reporter: Guillaume Blanc
• Created: 20/Sep/19 15:31
• Updated: 16/Oct/19 22:26
• Resolved: 21/Sep/19 12:45

Description

If multiple threads call TimerManager::stop, they will all be waiting on monitor for state to go to STOPPED.
As Dispatcher use monitor_.notify, only one of the thread will be awakened, other will stay waiting forever.

See attached test code to reproduce the issue (timing dependent).

Issue Links

• links to: GitHub Pull Request #1877