[THRIFT-4941] thrift compiler will not auto update gen-cpp directory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Affects Version/s: 0.13.0
• Fix Version/s: 0.13.0
• Component/s: C++ - Compiler
• Assignee: Jens Geyer
• Reporter: pengzhouhu
• Created: 27/Aug/19 08:50
• Updated: 10/Oct/19 22:53
• Resolved: 10/Oct/19 22:02

Description

thrift compiler will not auto update the files in the gen-cpp directory.

when we call t_generator::generate_program() and init_generator() in compiler\cpp\src\thrift\generate\t_generator.cc ,

'MKDIR' macro will ignore EEXIST, and throw on any other error, this will not give any reponse print on terminal. we used to update and generate the .h .cpp files in the whole directory.

1. delete the old folder and create new one, generate the file again.

2. throw errno directly and exit the terminal.

what`s your opinion about this?

code details:

// ignore EEXIST, throw on any other error
#ifdef _WIN32
#define MKDIR(x) { int r = _mkdir(x); if (r == -1 && errno != EEXIST) { throw (std::string(x) + ": ") + strerror(errno); } }
#else
#define MKDIR(x) { int r = mkdir(x, S_IRWXU | S_IRWXG | S_IRWXO); if (r == -1 && errno != EEXIST) { throw (std::string(x) + ": ") + strerror(errno); } }
#endif

Thanks.
Zhouhu.

Issue Links

• links to: GitHub Pull Request #1857