[THRIFT-4928] Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 0.11.0, 0.12.0
• Component/s: Java - Library

Environment

Ubuntu 16.04.3 LTS
Open JDK version "1.8.0_191" build 25.191-b12

• Assignee: Jens Geyer
• Reporter: xiaoqin.fu
• Created: 17/Aug/19 15:32
• Updated: 12/Jun/20 20:03
• Resolved: 12/Jun/20 20:03

Description

Operations: During Apache Thrift integration testing, I developed a calculator application with a client and a server. The client sent a computational command and get the result from the server. After I applied dynamic taint analyzer (distTaint), I found bugs from taint paths finally.

The source: org.apache.thrift.transport.TIOStreamTransport:
public int read(byte[] buf, int off, int len) throws TTransportException {
if (inputStream_ == null)

{ throw new TTransportException(TTransportException.NOT_OPEN, "Cannot read from null inputStream"); }

int bytesRead;
......
bytesRead = inputStream_.read(buf, off, len);
......
}

The sink: org.apache.thrift.transport.TTransport,
public int readAll(byte[] buf, int off, int len)
throws TTransportException {
......
if (ret <= 0)

{ throw new TTransportException( "Cannot read. Remote side has closed. Tried to read " + len + " bytes, but only got " + got + " bytes. (This is often indicative of an internal error on the server side. Please check your server logs.)"); }

......
}
Sensitive information about expected and actual reading lengths (len, got) is leaked.
The tainted path:
org.apache.thrift.transport.TIOStreamTransport -->
org.apache.thrift.transport.TTransport

I am going to submit a CVE, so please confirm this is not a true positive.

Issue Links

• is duplicated by: THRIFT-4922 Sensitive information is leaked from TTransport through a TTransportException
• is duplicated by: THRIFT-4923 An information leakage from TIOStreamTransport
• is duplicated by: THRIFT-4924 An information leakage from TSocket
• is duplicated by: THRIFT-4925 An information leakage from TSaslClientTransport
• is duplicated by: THRIFT-4926 An information leakage from TSaslTransport
• is duplicated by: THRIFT-4929 Sensitive information about socket input stream or output stream is leaked from TIOStreamTransport
• is duplicated by: THRIFT-4930 An information leakage about socket input stream or output stream from TIOStreamTransport to TSocket
• links to: GitHub Pull Request #2178