Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4926

An information leakage from TSaslTransport

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Invalid
    • Affects Version/s: 0.11.0, 0.12.0
    • Fix Version/s: None
    • Component/s: Java - Library
    • Labels:
      None

      Description

      In org.apache.thrift.transport.TSaslTransport,
      public void open() throws TTransportException {
      .......
      LOGGER.debug("{}: Start message handled", getRole());
      .......
      LOGGER.debug("{}: All done!", getRole());
      .......
      LOGGER.debug("{}: Main negotiation loop complete", getRole());
      .......
      LOGGER.debug("{}: SASL Client receiving last message", getRole());
      .......
      }

      Sensitive information about Role is leaked. The LOGGER.isDebugEnabled() conditional statements should be added:

      public void open() throws TTransportException {
      .......
      if (LOGGER.isDebugEnabled())
      LOGGER.debug("{}: Start message handled", getRole());
      .......
      if (LOGGER.isDebugEnabled())
      LOGGER.debug("{}: All done!", getRole());
      .......
      if (LOGGER.isDebugEnabled())
      LOGGER.debug("{}: Main negotiation loop complete", getRole());
      .......
      if (LOGGER.isDebugEnabled())
      LOGGER.debug("{}: SASL Client receiving last message", getRole());
      .......
      }

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jensg Jens Geyer
                Reporter:
                xiaoqin.fu xiaoqin.fu
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m