Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4908

reader&writer in golang's TBinaryProtocol is not necessary and misleading

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.13.0
    • Component/s: Go - Library
    • Labels:
      None

      Description

      while reading code in https://github.com/apache/thrift/blob/master/lib/go/thrift/binary_protocol.go

      It seems the reader and writer in TBinaryProtocol is not necessary, because this class is serialize/deserialize the struct and write/read the data stream via trans, `reader` & `writer` here are duplicated with `trans` in this struct

      if it's meaningful, I will submit a patch for this

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                chengguozhu CHENG GUOZHU
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Time Spent - 20m Remaining Estimate - 23h 40m
                  23h 40m
                  Logged:
                  Time Spent - 20m Remaining Estimate - 23h 40m
                  20m