[THRIFT-4896] cpp and c_glib include paths are added to source files when building

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Component/s: Build Process
• Assignee: James E. King III
• Reporter: Kevin Wojniak
• Created: 23/Jun/19 07:59
• Updated: 16/Oct/19 22:27
• Resolved: 01/Jul/19 18:07

Description

AM_CPPFLAGS is used by cpp and c_glib. They both add their include directories to AM_CPPFLAGS. However, since thrift header files names are generic (e.g. Processor.h) and can be reused per language, like with cpp and cocoa (as of 0.12), there is possibility for conflict due cpp and cocoa using same header file names. Automake supports target_CPPFLAGS instead which appears to limit the compile flags scope.

Issue Links

• links to: GitHub Pull Request #1821